-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8306] - Hide CORS and SSL for OBJ Gen2 #10776
Conversation
enabled && | ||
((isObjectStorageGen2Enabled && Boolean(endpoints)) || | ||
(isObjMultiClusterEnabled && Boolean(regions)) || | ||
Boolean(clusters)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just cleaned this up, logic should remain same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better😮💨
); | ||
|
||
const { data: bucketsData } = useObjectStorageBuckets( | ||
isObjectStorageGen2Enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to call this query when it's not Gen2, so I'm disabling it otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work without refreshing the page only after you've navigated to the bucket details page, as the bucket names are randomly generated each time due to MSW.
Can you clarify these verification steps? I must not be reading them right/am not super familiar with this project, because I wasn't able to verify the changes. I turned the Gen2
flag on and the MSW on. (Multicluster
was already on, since it's on in LD.) Then I navigated to http://localhost:3000/object-storage/buckets, and to a mock bucket's details page. I still saw CORS and SSL/TSL. I tried toggling the flag off->on + the MSW off-> on the bucket details page, and still saw CORS and SSL. Same with landing page and then navigating to bucket details.
I was unsure about the state of the Multicluster
flag, but tried with it off and Gen2
on too.
packages/manager/src/features/ObjectStorage/BucketDetail/AccessSelect.tsx
Outdated
Show resolved
Hide resolved
…sSelect.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Seems like you had the steps right. Here's a screen recording example.mov |
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know what I think happened? I must have had #10771 checked out. 🤦🏼♀️ I double-checked that it was a "Jaalah OBJ PR", but evidently not the right one.
✅ Confirmed CORS and SSL are hidden for OBJ Gen 2.
Approving since the lonely "Learn more." is non-blocking.
@@ -208,7 +207,19 @@ export const AccessSelect = React.memo((props: Props) => { | |||
</Link> | |||
. | |||
</Typography> | |||
) : null} | |||
) : ( | |||
// TODO: OBJGen2 - We need to handle link in upcoming PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we/Do we have a ticket to track this?
enabled && | ||
((isObjectStorageGen2Enabled && Boolean(endpoints)) || | ||
(isObjMultiClusterEnabled && Boolean(regions)) || | ||
Boolean(clusters)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better😮💨
Description 📝
CORS (Cross Origin Sharing) is not available for endpoint types E2 and E3. We will not be supporting SSL/TLS either at the moment.
Changes 🔄
For Gen2 (E2 & E3):
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Note
We have E2E tests ticket M3-8440 to cover all these scenarios separately.
Prerequisites
OBJ Gen2
flag is enabledVerification steps
Note
This will work without refreshing the page only after you've navigated to the bucket details page, as the bucket names are randomly generated each time due to MSW.
Access
tab and observe CORS is not renderedAs an Author I have considered 🤔
Check all that apply